add support for parent relationship #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
river/sync.go
Outdated
There was a problem hiding this comment.
use fmt.Errorf is better.
|
@siddontang Thanks for the comments. |
|
@EagleChen trivis-ci builds error, You can use goimports tool https://godoc.org/golang.org/x/tools/cmd/goimports later, which can handle your import files automatically. |
|
@siddontang |
siddontang
added a commit
that referenced
this pull request
Jul 30, 2015
add support for parent relationship
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only support
parentinbulkapi for elastic client. Other apis, such asget, don't support it. Supporting all the apis means too many changes to not only the source code but also tests.IMO, this is OK for
river, asriveronly usesbulkapi.